search

Lullabot / lubot

1 stars 0 forks source link

Initial cleanups recommended by jslint #19

Closed sirkitree closed 7 years ago

sirkitree commented 10 years ago

This is an initial run through jslint. There were two warnings that I didn't fix:

1. Unused 'req'.
    app.get('/', function (req, res) { // Line 22, Pos 24

Here, res is used but not req but we can get rid of req or the arguments will be out of order.

ericduran commented 10 years ago

what settings are being used for jshint?

This doesn't get added on this PR so there's room for it to keep going back and forth.

Lets add a .jshint file to the project first so we can all be on the same boat?

sirkitree commented 10 years ago

I used the default that came with the Sublime Text package. I was actually looking for how to add settings because there were some warnings I would have liked to ignore but couldn't find documentation on how to do that. Do you have any links for me?

ericduran commented 10 years ago

http://www.jshint.com/docs/

We just need a .jshintrc file with the settings we want to allow, etc..

in the doc root