search

Lullabot / lubot

1 stars 0 forks source link

[#5] Allow for the string !who in a factoid to be replaced with querying user's nick #27

Closed eojthebrave closed 9 years ago

eojthebrave commented 9 years ago

Resolves #5

eojthebrave commented 9 years ago

I added a few more changes to the branch which resolve #3 and #2. The code for all three of these tickets basically touches the same parts of the factoids script, so it was easier to roll it all together.

<@eojthebrave> lubot: joe is awesome
<lubot>  eojthebrave: Okay!
<@eojthebrave> lubot: tacos are awesome
<lubot>  eojthebrave: Okay!
<@eojthebrave> lubot: hi is <reply>Hey handsome.
<lubot>  eojthebrave: Okay!
<@eojthebrave> hi!
<lubot>  Hey handsome.
<@eojthebrave> joe?
<lubot>  joe is awesome
<@eojthebrave> tacos?
<lubot>  tacos are awesome
q0rban commented 9 years ago

Nice work, @eojthebrave! Made a few minor comments…

eojthebrave commented 9 years ago

Thanks for the review @q0rban. Fixed both of the things you pointed out.