search

Lullabot / windup

A Drupal starter theme
GNU General Public License v2.0
26 stars 8 forks source link

some node modules include .info file that breaks site #71

Closed krisbulman closed 8 years ago

krisbulman commented 9 years ago

As we all know, malformed theme.info files really break the site. See https://www.drupal.org/node/619542

The new issue for the core patch for 7.x is https://www.drupal.org/node/2329453

As it happens, some node_modules, like grunt-eslint include an lcov.info file that makes drupal shit the bed. This is going to be a pain point for a lot of people (like it has been for myself for 2 hours of backtracking).

krisbulman commented 9 years ago

This works for now

"scripts": {
  "postinstall": "find node_modules/ -name '*.info' -type f -delete"
}

Further reading https://www.drupal.org/node/2329453

There's also a core patch in https://www.drupal.org/node/619542#comment-9771891 which maybe should be included in docs.

RainbowArray commented 9 years ago

Yes, I've been using that postinstall line and it does the trick.

krisbulman commented 9 years ago

@carwin this is patched in 8 core, not in 7.

krisbulman commented 9 years ago

Disregard, of course patches don't make it into core in a timely manner :angry:

carwin commented 8 years ago

Looks like this has been patched for D7 in the last link you posted @krisbulman, is there anything to do here?

krisbulman commented 8 years ago

whoa shit, cool a committed patch to 7. all good, close out