Lullabot / windup

A Drupal starter theme
GNU General Public License v2.0
26 stars 8 forks source link

Oddity in node template #75

Closed krisbulman closed 8 years ago

krisbulman commented 8 years ago

https://github.com/Lullabot/windup/blob/master/templates/node.tpl.php#L85-L89

Some weirdness going on that would cause the header tag be closed but never opened if !$page

krisbulman commented 8 years ago

This looks to be where the regression was introduced, still not sure of the intent so i'll need clarification for the markup change. The original before the change looks ok to me except we may want to move the title prefix and suffix within the if statement.

https://github.com/Lullabot/windup/commit/3a8696b869468f385527bb0008579265306c1a5f#diff-5b9f6afb44ab29838bb17f3b2df40673L85

krisbulman commented 8 years ago

looks like just a line swap, probably an oversight. made a PR at https://github.com/Lullabot/windup/pull/76