Lullabot / windup

A Drupal starter theme
GNU General Public License v2.0
26 stars 8 forks source link

Added sass-lint and some basic rules. #82

Closed carwin closed 8 years ago

carwin commented 8 years ago

@wesruv or @krisbulman: I wrote a couple test files locally to test some of these rules, and it looks like everything is working. Take a look and see if anything jumps out at you.

This should resolve part of issue #56

carwin commented 8 years ago

You can test out some failing Sass with:

.style {
  color:pink;
  background: #777777;
  background: #777;
}
.style-thing_thing {
  background: "none";
  border: none;
}

%some__thing--else { oneline: true; }

#another-thing{
        color: purp
           opacity: .1;
}
wesruv commented 8 years ago

Me gusta!

It's a little hard to tell how much I like it, it doesn't check for errors, but that's kind of the compiler's job. Just used to Eslint yelling at me when I write bad code. Feel like my expectations for this as a linter should be a different.

It is definitely good enough to replace the Ruby alternative and looks like it'll keep improving.

@carwin shall we merge?

carwin commented 8 years ago

Done. Thanks for lookin'.