Lullabot / windup

A Drupal starter theme
GNU General Public License v2.0
26 stars 8 forks source link

PHP fatal when viewing a node revision #94

Closed m4olivei closed 8 years ago

m4olivei commented 8 years ago

When viewing a node revision, eg. /node/1/revisions/1/view the theme throws a Fatal error like this:

Call to a member function bundle() on string in <path_undisclosed_to_protect_the_innocent>/windup.theme on line 43

That is this line: https://github.com/Lullabot/windup/blob/8.x-1.x/windup.theme#L43.

The problem is that D8 isn't consistent about parameter conversion for the node and node revision routes. There is an issue slated to Drupal 8.2.x to fix this: https://www.drupal.org/node/2730631.

In the interim, the solution is to grab the raw parameter from the route matching service and load the node up ourselves.

PR incoming.