search

LulumiProject / lulumi-browser

Lulumi-browser is a lightweight browser coded with Vue.js 2 and Electron.
Apache License 2.0
437 stars 90 forks source link

PDF Viewer fails with GET parameters in url #22

Open MarZab opened 7 years ago

MarZab commented 7 years ago

Looks like the new electon built in pdf viewer works great but there is a issue with loading pdf's with GET parameters.

Looking at the dev tools I can see the URL of the pdf gets cut off at the first &.

for https://domain.com/printPDF.php?CID=23323&PID=12412

<embed id="plugin" type="application/x-google-chrome-pdf" src="https://domain.com/printPDF.php?CID=23323" stream-url="blob:chrome://pdf-viewer/524829d4-578d-4bcf-866d-fe608bd4fac8" .. snip .. >

qazbnm456 commented 7 years ago

@MarZab Hi, there. Thanks for reporting this. Would you mind providing a valid link again that reproduces the issue? Since the link you provided is not accessible.

MarZab commented 7 years ago

for example

http://digitalcommons.unl.edu/cgi/viewcontent.cgi?article=1118&context=podimproveacad

screen shot 2017-07-13 at 16 41 07

qazbnm456 commented 7 years ago

@MarZab Thank you! The link does reproduce the issue, and I can confirm that this issue is related to PDFView's implementation side in Electron. I'll see if I can propose a PR to fix this. Good catch, though.

qazbnm456 commented 7 years ago

@MarZab I've proposed the PR, and here is the link if you are interested in following up the PR.

MarZab commented 7 years ago

Great job! Looks like I misjudged the source of that bug :)

qazbnm456 commented 7 years ago

https://github.com/electron/electron/pull/10008 has been merged and this issue will be closed once the next release of Lulumi comes out.