Build failing discourages potential users

[dandv]

A friend of mine wanted to install jquery-datatables but GitHub shows that the build is failing, so they chose reactive-table instead.

[gjolund]

Hey @dandv,

I actually just spent a lot of time writing comprehensive tests for jquery-datatables, and the build failing is due to inconsistent testing on travis-CI vs my local machine.

If you run the tests locally you will see that they are all passing and cover 100% of the core features.

Also I plan on release reactive configuration options, querying, and sever defined publications by EOD today.

Haven't played around with reactive-table yet, does it handle pagination over large datasets well?

-Austin

[gjolund]

Discussion on meteor-talk with problem code reference

[dandv]

Hey @austinrivas, thanks for the quick turnaround. I've used reactive-datatables for smaller tables, and pagination isn't implemented yet. Our use case involves a small table, but we need proper sorting for number types, and reactive-tables would have to reinvent the wheel in that regard.

[gjolund]

Turns out the the inconsistency was the result of phantomJS not support the bind method.

This bug is described in detail here

I was able to figure this out by using the npm spacejam tinytest runner and running tinytest locally in phantomJS, this will now become and additional step I take prior to releasing package updates.

My solution to this issue was to use the _.bind method instead of the Function.prototype.bind method.

All green now :)

[chadrik]

@dandv, tell your friend he made a mistake and bet on the wrong horse :)

[dandv]

Very cool! Hey @johnallen, build is passing now!