Fix for Issue #343 - Githubissues

LumaPictures / pymel

Python in Maya Done Right

Other

490 stars 131 forks source link

Fix for Issue #343 #384

Closed kartikg3 closed 7 years ago

kartikg3 commented 8 years ago

Modify getClassfication to support satisfies kwarg. Issue #343.

Please cherry-pick commit - 88dcb72 i.e. only cherry-pick these files:

pymel/core/general.py pymel/core/nodetypes.py tests/test_nodetypes.py

Thank you.

kartikg3 commented 7 years ago

Hey guys,

Are there any issues keeping this pull request from being merged? Let me know and I will make the changes.

Thanks.

Regards, Kartik

kartikg3 commented 7 years ago

Hey guys,

Pinging on this again. Please let me kw if there is anything keeping you from merging this request, and I will make the changes.

pmolodo commented 7 years ago

Just cherry-picked as requested and pushed. In future, though, would be easier if you could create a pull request yourself, with only the changes you want merged. This PR had a bunch of duplicate commits, which were already merged, and then a commit reverting some of these already-merged changes. Was definitely a little confusing. Regardless, though, appreciate the submission. Thanks!

kartikg3 commented 7 years ago

Thanks Paul. I realized that with this pull request that was done a while ago. I had munged up some extra unnecessary commits in this branch that was hard to cleanup and roll back.

As you can see, my other PRs have not been this way.

Thank you for merging!