search

LumaPictures / pymel

Python in Maya Done Right
Other
479 stars 130 forks source link

Fixes bug of Display & Render layer while removing the members from layer #417

Closed laslavinco closed 5 years ago

laslavinco commented 5 years ago

In class DisplayLayer & RenderLayer, the method removeMembers had a bug, since maya discontinued cmds.editDisplayLayerMembers's remove argument. In order to make this method work i added a work around.

pmolodo commented 5 years ago

Thanks for the PR, laslavinco! I've confirmed that this is indeed a problem for DisplayLayer.removeMembers. However, it looks like RenderLayer.removeMembers still works fine - editRenderLayerMembers still has a remove flag, and our tests for it still pass. It's also still in the docs, and isn't marked deprecated or anything.

pmolodo commented 5 years ago

Hi Akshay - I've gone ahead and merged your first commit (for DisplayLayer), but not your second (for RenderLayer), as it seems to be working. I've also added some tests for DisplayLayer so this doesn't slip by in the future. Thanks for your contribution!

laslavinco commented 5 years ago

Hi Akshay - I've gone ahead and merged your first commit (for DisplayLayer), but not your second (for RenderLayer), as it seems to be working. I've also added some tests for DisplayLayer so this doesn't slip by in the future. Thanks for your contribution!

@elrond79 Always a pleasure. :)