search

LumaPictures / usd-qt

Reusable Qt Components for Pixar's USD
Other
153 stars 40 forks source link

PyQt compatibility #12

Closed csaez closed 6 years ago

csaez commented 6 years ago

Hi there,

The triggered signal on QAction is implemented slightly different in PyQt (checked argument is required) vs PySide (checked is optional), these changes attempt to make the project work in both cases.

Changes have been tested with PySide, PySide-2, PyQt-4.8 and PyQt-5 (via Qt.py).

nrusch commented 6 years ago

Interesting... I can't reproduce this with PyQt 4.8.4 (bound using a Qt.py). Which versions of PyQt was this discovered with?

csaez commented 6 years ago

Hi Nathan, Apparently this is not the case anymore (or I couldn't reproduce it), but it def was the case on previous iteration of usd-qt. I just released a copy of usd-qt without the patch at work, I will come back to this with more details if we find issues on some of our more exotic environments :+1:

Cheers