search

LumaPictures / usd-qt

Reusable Qt Components for Pixar's USD
Other
153 stars 40 forks source link

Fix data changed signal (PyQt-5 compatible) #21

Closed csaez closed 6 years ago

csaez commented 6 years ago

Fixes https://github.com/LumaPictures/usd-qt/issues/20 Tested with PySide-1.2, PySide-2.0, PyQt-4.11 and PyQt-5.9

cc @nrusch

csaez commented 6 years ago

Any chance to get this reviewed please?

nrusch commented 6 years ago

Sorry, it's been a busy week production-wise, which always takes priority.

I want to try this out in our internal application environments as well before merging; I'll try to do that first thing today.

On Thu, Oct 11, 2018, 04:54 Cesar Saez notifications@github.com wrote:

Any chance to get this reviewed please?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/LumaPictures/usd-qt/pull/21#issuecomment-428926980, or mute the thread https://github.com/notifications/unsubscribe-auth/AAslu-SiW5lnDpiAB8mrhvIfUcFa2I8Jks5ujzFXgaJpZM4XQA_l .

nrusch commented 6 years ago

Hey @csaez, are you testing this using a shim module like Qt.py? I only ask because I don't think PyQt (4 or 5) will work at all without one.

csaez commented 6 years ago

Hi @nrusch, Yes, I'm using Qtpy-1.1.0 and its QT_PREFERRED_BINDING env variable for testing (more details in https://github.com/LumaPictures/usd-qt/issues/20).

nrusch commented 6 years ago

OK. Merging this, and then I'll update the README with a note about the Python API requirements.