search

LumaPictures / usd-qt

Reusable Qt Components for Pixar's USD
Other
153 stars 41 forks source link

Update Layer Save Behavior in Text Editor #25

Closed superfunc closed 5 years ago

superfunc commented 5 years ago

I may be missing something here, I'm not very Qt-savvy, but it seems like the apply button in this dialog would save the contents back to the layer, currently it does not.

nrusch commented 5 years ago

The editor is only really meant to edit the in-memory representation of the layer. We don't want to presume that the changes should always be persisted to disk when they are applied.

superfunc commented 5 years ago

Makes sense, thanks!

chadrik commented 5 years ago

This issue does bring to light that in our effort to provide widgets that are useful out-of-the-box, we run the risk of making to assumptions about how they will be used. We've implemented a system for customizing menu items in the hopes of allowing these assumptions to be overridden or extended (at least in the case of menus), but if you feel that we should walk back some of this functionality and ensure that the widgets remain less opinionated, or provide more/better customizability we're certainly willing to entertain either option.

On Fri, Nov 30, 2018 at 10:10 PM superfunc notifications@github.com wrote:

Makes sense, thanks!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/LumaPictures/usd-qt/pull/25#issuecomment-443403144, or mute the thread https://github.com/notifications/unsubscribe-auth/AAD3EzVoB_f8gKqE8LeRQU4Zghi-1Vxuks5u0h1RgaJpZM4Ysahu .

superfunc commented 5 years ago

After further thought, I think this setup lines up with my thinking as well. We've been developing some internal widgets very recently; and to reuse them across DCCs and Usdview, we've set them up similarly, with dcc specific wrappers.