search

LumaPictures / usd-qt

Reusable Qt Components for Pixar's USD
Other
153 stars 40 forks source link

HierarchyStandardModel: invalid icon filepath? #9

Open csaez opened 6 years ago

csaez commented 6 years ago

Hi, I'm not sure if this is a bug, but while trying to make the HierarchyStandardModel icons work today I realized that the running code is moved to pxr.UsdQt namespace after build, leaving the icons behind (pxr.usdQt) and making the relative paths to fail. https://github.com/LumaPictures/usd-qt/blob/35b01eaf71c5ebaf6262892ddc5584a5cae45184/pxr/usdQt/hierarchyModel.py#L279-L280

Is there any plans to integrate the use of resources with the build system? Or even better, moving to QResource? Is this something we can help with?

Cheers!

nrusch commented 6 years ago

Hi @csaez, thanks for the heads-up. We aren't using the icons internally, so I hadn't run into this one. It doesn't look like they're being installed at all by the build process, so that would definitely be one of the first things to fix.

I also think it would be great to avoid hardcoding paths to resources into code, so I would be in favor of moving to QResource. If you're interested in tackling that, or have already done it internally and are able to submit it back as a PR, I think it make a welcome addition.

csaez commented 6 years ago

Hi Nathan, This is not an issue for us at the moment as I followed your advice moving to a subclass of HierarchyBaseModel (thanks!).

I will keep the move to QResource in mind moving forward tho :+1: Cheers