search

LumeWeb / web

Monorepo for Project
MIT License
1 stars 3 forks source link

fix: missing favicon #261

Open forbesus opened 1 month ago

forbesus commented 1 month ago

ref

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: 68dc4726230a84b8d042023a1d14e98d97c6995e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

ditorodev commented 1 month ago

Thanks for the contribution @forbesus! This looks good, small change tho, no need to be passing the favicon as a parameter as we dont plan to change the favicon

forbesus commented 1 month ago

Hello @ditorodev Some browser like safari is not supporting svg favicon now

https://caniuse.com/link-icon-svg image

Are you still okay with this?

pcfreak30 commented 3 weeks ago

@forbesus if you want me to merge/use this, please squash all commits into 1 conventional commit. There is too much noise here, and im not wanting 5-6 commits for this to be in the repo.

Kudos.

forbesus commented 3 weeks ago

Hello @pcfreak30 I just squashed all commits