Closed desmondinho closed 2 weeks ago
The changes in this pull request involve modifications to various components and documentation related to the LumexIcon
within the LumexUI
framework. Key updates include the removal of the locked
parameter for the LumexIcon
in the navigation structure, adjustments to the viewBox
attribute casing in several components, new examples showcasing the LumexIcon
in different colors and styles, and the introduction of a Dimensions
struct to manage icon sizes. Additionally, new Razor components for documentation and previews have been created to enhance user understanding and interaction.
File Path | Change Summary |
---|---|
docs/LumexUI.Docs.Client/Common/Navigation/NavigationStore.cs | Removed locked: true parameter from LumexIcon entry in navigation categories. |
docs/LumexUI.Docs.Client/Components/ComponentLinks.razor | Changed ViewBox attribute to lowercase viewBox for BlazorIcon and GithubIcon . |
docs/LumexUI.Docs.Client/Components/Header.razor | Changed ViewBox attribute to lowercase viewBox for LumexIcon . |
docs/LumexUI.Docs.Client/Pages/Components/Icon/Examples/Colors.razor | Added multiple LumexIcon instances with different colors from ThemeColor enumeration. |
docs/LumexUI.Docs.Client/Pages/Components/Icon/Examples/CustomStyles.razor | Introduced a LumexIcon component with Icons.Rounded.Bed , size 40, and class text-indigo-500 . |
docs/LumexUI.Docs.Client/Pages/Components/Icon/Examples/DimensionsFont.razor | Added multiple LumexIcon instances with varying sizes for the "accessibility" icon. |
docs/LumexUI.Docs.Client/Pages/Components/Icon/Examples/DimensionsSvg.razor | Introduced multiple LumexIcon instances with varying sizes for Icons.Rounded.Home . |
docs/LumexUI.Docs.Client/Pages/Components/Icon/Examples/Usage.razor | Added several LumexIcon instances with different properties from the Icons.Rounded enumeration. |
docs/LumexUI.Docs.Client/Pages/Components/Icon/Icon.razor | Created a structured documentation layout detailing the usage, colors, dimensions, custom styles, and API for the LumexIcon component. |
docs/LumexUI.Docs.Client/Pages/Components/Icon/PreviewCodes/Colors.razor | Introduced a new component for rendering color icons with a PreviewCode element. |
docs/LumexUI.Docs.Client/Pages/Components/Icon/PreviewCodes/CustomStyles.razor | Introduced a new component for rendering custom styles related to icons with a PreviewCode element. |
docs/LumexUI.Docs.Client/Pages/Components/Icon/PreviewCodes/DimensionsFont.razor | Introduced a new component for rendering font dimensions associated with icons with a PreviewCode element. |
docs/LumexUI.Docs.Client/Pages/Components/Icon/PreviewCodes/DimensionsSvg.razor | Created a new component for rendering SVG icon dimensions with a PreviewCode element. |
docs/LumexUI.Docs.Client/Pages/Components/Icon/PreviewCodes/Usage.razor | Introduced a new component for rendering interactive code snippets with a PreviewCode element. |
src/LumexUI/Common/Models/Dimensions.cs | Introduced a new Dimensions struct with properties W and H , and constructors for width and height. |
src/LumexUI/Components/Icon/LumexIcon.razor | Changed viewBox attribute from dynamic to a static value. |
src/LumexUI/Components/Icon/LumexIcon.razor.cs | Removed ViewBox property, updated FontIconStyle to nullable, and moved dimension enforcement logic to OnParametersSet method. |
In the garden of code, where icons play,
A rabbit hops by, brightening the day.
With colors and sizes, they dance and they twirl,
EachLumexIcon
shines, a gem in the swirl.
From navigation to styles, oh what a delight,
Hooray for the changes, letβs hop with delight! πβ¨
Attention: Patch coverage is 55.55556%
with 4 lines
in your changes missing coverage. Please review.
Project coverage is 95.92%. Comparing base (
19b89dc
) to head (f46b550
). Report is 41 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
src/LumexUI/Components/Icon/LumexIcon.razor.cs | 33.33% | 3 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Ignoring codecov patch failure for the time being.
Summary by CodeRabbit
New Features
LumexIcon
component with various colors and dimensions.LumexIcon
component, detailing usage, customization, and API references.Improvements
LumexIcon
component to improve clarity and maintainability.Bug Fixes
viewBox
attribute in multiple components to align with standard HTML conventions.