search

LumiGuide / haskell-opencv

Haskell binding to OpenCV-3.x
Other
154 stars 44 forks source link

Basic tracking support #80

Closed tolysz closed 7 years ago

tolysz commented 7 years ago

Basic tracking support Works but needs more work. It can be merged.

tolysz commented 7 years ago

I fix the code according to your suggestions, the amend/force push is destroying the review. Maybe the better is to have more commits but then "merge with squash" via github?

basvandijk commented 7 years ago

It's no problem to destroy the review. If you've addressed the points then I can review again and merge it.

basvandijk commented 7 years ago

Hi @tolysz, I think your forgot to add opencv-extra/include/tracker.hpp because I get the build error:

src/OpenCV/Extra/Tracking.cpp:6:24: error:
     fatal error: tracking.hpp: No such file or directory

Could you add it please? Then I'll merge.

tolysz commented 7 years ago

Ok, re-added. ;) the git reset is to blame. On the up side, it was enough or re-tries to make travis green!

basvandijk commented 7 years ago

Awesome example!