LumiSpy / lumispy

Luminescence data analysis with HyperSpy.
https://lumispy.org
GNU General Public License v3.0
26 stars 17 forks source link

Extend functionality of crop_edges #129

Open jlaehne opened 2 years ago

jlaehne commented 2 years ago

Describe the context

crop_edges is a wrapper function for inav that takes the parameter crop_px and removes as many pixels from all sides of a map.

Describe the functionality you would like to see.

To make this function more versatile, it would make sense to alternatively allow the following sets of parameters:

Additional information

@jordiferrero , you originally implemented this function. Would this extension make sense to you? We have a student that could implement it.

jordiferrero commented 2 years ago

This makes sense. I initially implemented this function because I always run this "simple" cropping during pre-processing. It would be great for a student to do it. Just make sure the original functionality is still working (so when you only pass 1 parameter, it crops all sides equally).

jlaehne commented 2 years ago

Of course, one should be able to pass either of the three sets of parameters mentioned above.

jordiferrero commented 2 years ago

Glad to hear a student is coming to help you with coding :-)