Codecov Report

Merging #131 (b6f0a11) into main (ee6b0c4) will decrease coverage by 0.11%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
- Coverage   96.69%   96.58%   -0.12%     
==========================================
  Files          11       11              
  Lines         575      556      -19     
==========================================
- Hits          556      537      -19     
  Misses         19       19

Impacted Files	Coverage Δ
lumispy/signals/cl_spectrum.py	`98.33% <ø> (-0.13%)`	:arrow_down:
lumispy/signals/common_transient.py	`100.00% <ø> (ø)`
lumispy/signals/el_spectrum.py	`100.00% <ø> (ø)`
lumispy/signals/luminescence_transient.py	`100.00% <ø> (ø)`
lumispy/signals/luminescence_transientspec.py	`100.00% <ø> (ø)`
lumispy/signals/pl_spectrum.py	`100.00% <ø> (ø)`
lumispy/signals/common_luminescence.py	`96.96% <100.00%> (ø)`
lumispy/signals/luminescence_spectrum.py	`92.73% <100.00%> (-0.12%)`	:arrow_down:
lumispy/utils/axes.py	`98.06% <100.00%> (-0.03%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ee6b0c4...b6f0a11. Read the comment docs.

ericpre commented 2 years ago

Is it worth enabling github integration? https://lgtm.com/help/lgtm/github-apps-integration

jlaehne commented 2 years ago

Is it worth enabling github integration? https://lgtm.com/help/lgtm/github-apps-integration

I think it is definetely something we should look into. Would be great to have such an automated code review to avoid introducing new inconsistencies.

LumiSpy / lumispy

lgtm.com fixes #131

Description of the change

Progress of the PR

Codecov Report