We have some low hanging fruit in increasing the test coverage of LumiSpy:
[x] px_to_nm_grating_solver in signals/luminescence_spectrum.py is not covered [See codecov, lines 291-310]
[x] For to_eV and to_invcm in signals/luminescence_spectrum.py, the case where the variance is a single int/float is not covered when inplace=True. See codecov, lines 154-161 & 309-316
[x] scale_by_exposure in signals/common_luminescence.py is missing coverage for the situation where ("Signal.quantity") == "Intensity (Counts)"See codecov, lines 154-155
[x] remove_spikes in signals/cl_spectrum.py is missing coverage for show_diagnosis_histogramSee codecov, line 92
[x] solve_grating_equation in utils/axes.py is missing coverage for axis being non-uniform DataAxisSee codecov, line 485
remove_background_from_file misses some tests for warnings/errors, but as it will be deprecated is not worth implementing.
I assign px_to_nm_grating_solver in signals/luminescence_spectrum.py is not covered [See codecov, lines 291-310] to myself. Will work on it in the next 2 weeks.
We have some low hanging fruit in increasing the test coverage of LumiSpy:
[x]
px_to_nm_grating_solver
insignals/luminescence_spectrum.py
is not covered [See codecov, lines 291-310][x] For
to_eV
andto_invcm
insignals/luminescence_spectrum.py
, the case where the variance is a singleint/float
is not covered wheninplace=True
. See codecov, lines 154-161 & 309-316[x]
scale_by_exposure
insignals/common_luminescence.py
is missing coverage for the situation where("Signal.quantity") == "Intensity (Counts)"
See codecov, lines 154-155[x]
remove_spikes
insignals/cl_spectrum.py
is missing coverage forshow_diagnosis_histogram
See codecov, line 92[x]
solve_grating_equation
inutils/axes.py
is missing coverage for axis being non-uniformDataAxis
See codecov, line 485remove_background_from_file
misses some tests for warnings/errors, but as it will be deprecated is not worth implementing.