Closed jlaehne closed 2 years ago
Merging #134 (5539b96) into main (004a7dd) will increase coverage by
1.78%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #134 +/- ##
==========================================
+ Coverage 96.58% 98.36% +1.78%
==========================================
Files 11 11
Lines 556 550 -6
==========================================
+ Hits 537 541 +4
+ Misses 19 9 -10
Impacted Files | Coverage Δ | |
---|---|---|
lumispy/signals/luminescence_spectrum.py | 94.94% <100.00%> (+2.16%) |
:arrow_up: |
lumispy/utils/axes.py | 100.00% <100.00%> (+1.93%) |
:arrow_up: |
lumispy/signals/cl_spectrum.py | 100.00% <0.00%> (+1.69%) |
:arrow_up: |
lumispy/signals/common_luminescence.py | 100.00% <0.00%> (+3.03%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 004a7dd...5539b96. Read the comment docs.
Description of the change
to_eV
andto_invcm
changing the variance of the original signal when the variance is a singleint/float
andinplace=False
(turned up asinplace=True
was not covered by the test despite it should have been).solve_grating_equation
that turned up as a missing coverage for the line checking the axes type version.Progress of the PR