Closed 0Hughman0 closed 1 year ago
Base: 98.36% // Head: 94.94% // Decreases project coverage by -3.41%
:warning:
Coverage data is based on head (
e8c36f2
) compared to base (a3ac072
). Patch coverage: 0.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Sorry, black
somehow got carried away and 'fixed' a bunch of files that aren't mine 😬.
Sorry, still did not find the time for a detailed look at the code. But already the demo video is very cool.
As suggested by @ericpre in https://github.com/LumiSpy/lumispy/issues/139#issuecomment-1231397069 it would be quite useful for any hyperspectral signal (EDX, EELS) and not only luminescence - so we should at least discuss incorporating it upstream.
For linescans, I could imagine an equivalent tool (possibly covered by the same function) that plots intensity traces for the chosen spectral ROIs.
Great thanks.
With some guidance I would be happy to help adapt the code to be incorporated into hyperspy.
I think knowing how best to handle the various shapes of data will be the challenge here.
@LMSC-NTappy check out this PR
With some guidance I would be happy to help adapt the code to be incorporated into hyperspy.
I still think an upstream contribution would be great. To have the functionality available more quickly, a way forward could be to merge it in LumiSpy and make a release. Once it is also available in HyperSpy, we could deprecate it on the LumiSpy side.
I think knowing how best to handle the various shapes of data will be the challenge here.
Currently you have a span-ROI, but in a 2D map one would have rectangular ROIs to select parts of the data for the filtering. Would be surely nice to have that as well. Actually, once we integrate more functionality for Streak-Camera-Images, it would be helpful to have 2D signal support for LumiSpy as well.
@0Hughman0 could you solve the merge conflicts?
Hi,
Currently rushing to write up my PhD!
Would be happy to do this, but will have to wait until likely April.
@LMSC-NTappy check out this PR
Will do!
Any time to upstream this to HyperSpy, could possibly make it into the v2.0 release scheduled for September?
Hiya,
Sorry for the delay, thanks for your patience!
I'll have a go at getting this going swiftly.
I'm trying to find when the release is scheduled for 2.0, but no luck? I can hopefully sort in the next few days.
I guess I should make a new PR on the hyperspy repo?
Change's I'll make:
Sound like a good plan
I'm trying to find when the release is scheduled for 2.0, but no luck? I can hopefully sort in the next few days. In general, the idea for now mentioned in some other PRs is to release it in the course of September (though looks more like late September already I would say).
I guess I should make a new PR on the hyperspy repo? I think that would be the best strategy, one can transfer PRs, but I think it would be cleaner to start a new one - @ericpre has more experience with that though.
This PR has been moved to one for hyperspy:
Description of the change
A few sentences and/or a bulleted list to describe and motivate the change:
Progress of the PR
Minimal example of the bug fix or the new feature