LumiSpy / lumispy

Luminescence data analysis with HyperSpy.
https://lumispy.org
GNU General Public License v3.0
26 stars 17 forks source link

fix codeql warnings and notes #162

Closed jlaehne closed 1 year ago

jlaehne commented 1 year ago

Description of the change

Fixes warnings and notes from CodeQL scan: https://github.com/LumiSpy/lumispy/runs/9372886548

Progress of the PR

codecov-commenter commented 1 year ago

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (1ed2791) compared to base (da723d8). Patch coverage: 100.00% of modified lines in pull request are covered.

:exclamation: Current head 1ed2791 differs from pull request most recent head 68bfbc0. Consider uploading reports for the commit 68bfbc0 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #162 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 11 11 Lines 548 548 ========================================= Hits 548 548 ``` | [Impacted Files](https://codecov.io/gh/LumiSpy/lumispy/pull/162?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LumiSpy) | Coverage Δ | | |---|---|---| | [lumispy/utils/axes.py](https://codecov.io/gh/LumiSpy/lumispy/pull/162/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LumiSpy#diff-bHVtaXNweS91dGlscy9heGVzLnB5) | `100.00% <ø> (ø)` | | | [lumispy/signals/cl\_spectrum.py](https://codecov.io/gh/LumiSpy/lumispy/pull/162/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LumiSpy#diff-bHVtaXNweS9zaWduYWxzL2NsX3NwZWN0cnVtLnB5) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LumiSpy). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LumiSpy)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

jordiferrero commented 1 year ago

Can you quickly solve the conflict. It's just the docs-fix you made in #163