LumiSpy / lumispy

Luminescence data analysis with HyperSpy.
https://lumispy.org
GNU General Public License v3.0
25 stars 17 forks source link

Replace imgmath by mathjax sphinx-extension #172

Closed jlaehne closed 1 year ago

jlaehne commented 1 year ago

Requirements

As brought up in #166, math is not rendering any more in the ReadTheDocs. AS brought up by @hakonanes in https://github.com/hyperspy/hyperspy/pull/3050#issuecomment-1386765990 sphinx.ext.mathjax should be working, while sphinx.ext.imgmath seems to be broken (in both HyperSpy and LumiSpy). Therefore replacing the extension.

Fixes #166

Progress of the PR

codecov-commenter commented 1 year ago

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (fb6b620) compared to base (f7f3cbb). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #172 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 11 11 Lines 503 503 ========================================= Hits 503 503 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LumiSpy). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LumiSpy)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

jlaehne commented 1 year ago

Does work indeed: https://lumispy--172.org.readthedocs.build/en/172/user_guide/signal_axis.html

ericpre commented 1 year ago

@jlaehne, do you want to squash the last 2 commits?

jlaehne commented 1 year ago

@jlaehne, do you want to squash the last 2 commits?

I just performed a squash and merge, I think a single commit including changelog is enough for this small change.

jordiferrero commented 1 year ago

Thanks for that!