LumiSpy / lumispy

Luminescence data analysis with HyperSpy.
https://lumispy.org
GNU General Public License v3.0
25 stars 17 forks source link

Crop edges update simplified #177

Open jordiferrero opened 1 year ago

jordiferrero commented 1 year ago

Description of the change

Following the request to make #142 cleaner and separate the crop_ede function from other changes, this is the clean version of the PR, aiming to extend the functionality of crop_edges.

Progress of the PR

codecov-commenter commented 1 year ago

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (8d66281) compared to base (cc5507b). Patch coverage: 100.00% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #177 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 12 12 Lines 545 614 +69 ========================================= + Hits 545 614 +69 ``` | [Impacted Files](https://codecov.io/gh/LumiSpy/lumispy/pull/177?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LumiSpy) | Coverage Δ | | |---|---|---| | [lumispy/signals/common\_luminescence.py](https://codecov.io/gh/LumiSpy/lumispy/pull/177?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LumiSpy#diff-bHVtaXNweS9zaWduYWxzL2NvbW1vbl9sdW1pbmVzY2VuY2UucHk=) | `100.00% <100.00%> (ø)` | | | [lumispy/utils/signals.py](https://codecov.io/gh/LumiSpy/lumispy/pull/177?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LumiSpy#diff-bHVtaXNweS91dGlscy9zaWduYWxzLnB5) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LumiSpy). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LumiSpy)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

jordiferrero commented 1 year ago

As discussed, this is now ready for review @jlaehne . Hope it is easier to see what is new.