search

LumiSpy / lumispy

Luminescence data analysis with HyperSpy.
https://lumispy.org
GNU General Public License v3.0
25 stars 17 forks source link

Release_v0.2.2 #183

Closed jlaehne closed 1 year ago

jlaehne commented 1 year ago

Description of the change

I'd like to push a patch release before the tutorial at the CL-EBIC workshop next week.

Progress of the PR

ericpre commented 1 year ago

I'd like to push a patch release before the tutorial at the CL-EBIC workshop next week.

Do you think that we should release a hyperspy patch release asap to avoid potential troubles with the random number generation changes in recent version of dask?

jlaehne commented 1 year ago

I'd like to push a patch release before the tutorial at the CL-EBIC workshop next week.

Do you think that we should release a hyperspy patch release asap to avoid potential troubles with the random number generation changes in recent version of dask?

Haven't looked into the details, but sounds sensible and might not hurt.

jlaehne commented 1 year ago

I just realized that for a map the new centroid function, similar to e.g. valuemax and indexmax in HyperSpy returns a BaseSignal with 2 navigation dimensions and 0D signal, which theoretically makes sense, but is inconvenient for plotting as it plots including the navigator, which makes little sense for 0D signals, and colormap cannot be changed.

In contrast, estimate_peak_width returns the transposed signal, thus Signal2D object without navigation dimensions, which is more convenient for plotting - and is okay in the sense that it is just an image of values for the different positions.

We should consider making that more consistent also in HyperSpy (e.g. with the 2.0 release), but if we release the centroid function here and then decide to change the behavior again, we unnecessarily break the API.

jlaehne commented 1 year ago

I changed the centroid output type to Signal2D in #184 and opened an issue for HyperSpy https://github.com/hyperspy/hyperspy/issues/3111

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (9db99bd) 100.00% compared to head (31e2aa6) 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #183 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 12 12 Lines 554 554 ========================================= Hits 554 554 ``` | [Impacted Files](https://codecov.io/gh/LumiSpy/lumispy/pull/183?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LumiSpy) | Coverage Δ | | |---|---|---| | [lumispy/release\_info.py](https://codecov.io/gh/LumiSpy/lumispy/pull/183?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LumiSpy#diff-bHVtaXNweS9yZWxlYXNlX2luZm8ucHk=) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LumiSpy). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LumiSpy)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.