search

LumiSpy / lumispy

Luminescence data analysis with HyperSpy.
https://lumispy.org
GNU General Public License v3.0
26 stars 18 forks source link

fixed test #187

Closed Attolight-NTappy closed 1 year ago

Attolight-NTappy commented 1 year ago

Fixes the failing test in #185

codecov-commenter commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (ca4d57d) 100.00% compared to head (0c6d1a9) 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #187 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 12 12 Lines 554 554 ========================================= Hits 554 554 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LumiSpy). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LumiSpy)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

ericpre commented 1 year ago

Does remove_spikes have any added functionalities in comparison to Signal1D.spikes_removal_tool? If not, is it worth keeping it?

Attolight-NTappy commented 1 year ago

From what I see in the code, it mostly allows to choose whether it is done in place or not.

(I just discover now that the test is still flaky)

jlaehne commented 1 year ago

Does remove_spikes have any added functionalities in comparison to Signal1D.spikes_removal_tool? If not, is it worth keeping it?

Indeed, apart from the additional inplace option, which should be easy to contribute upstream, and the possibility to build a signal_mask from a luminescence_roi, it is only a wrapper function with different defaults (interactive=False).

@jordiferrero, you contributed this function, what was the original motivation behind it? If we are just changing defaults of an existing function, it does not really make sense to keep it up.