Open jlaehne opened 9 months ago
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Attention: Patch coverage is 97.95918%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 99.46%. Comparing base (
9c402c0
) to head (88d1c3d
). Report is 20 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
lumispy/signals/common_luminescence.py | 97.53% | 2 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description of the change
Move axis conversion code to
CommonLuminescence
class to make it available toLuminescenceTransientSpectrum
signals.Handle inheritance for slicing of
LuminescenceTransientSpectrum
:signal_type = 'TransientSpec'
(classTransientSpectrumCasting
)TransientSpec
is initialized in 1D withaxes_manager[-1].units
being a time unit, switch toLumiTransient
class, otherwise switch toLuminescence
classProgress of the PR