Closed jlaehne closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 100.00%. Comparing base (
681442a
) to head (dc82df1
). Report is 1 commits behind head on main.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@ericpre is there a way to make the hyperspy package_and_test
workflow available for lumispy or should I work on simplifying the copy made here instead? As far as I can see, in particular `l65 is incompatible with being called from outside the hyperspy organization.
Can you try now after https://github.com/hyperspy/.github/commit/c5376fc1205d57561ac5e15620df4e5799465a5c?
Can you try now after hyperspy/.github@c5376fc?
Still trying to run git remote add upstream https://github.com/hyperspy/lumispy.git
:
https://github.com/LumiSpy/lumispy/actions/runs/8944482220/job/24571487005?pr=211
Can you try now after hyperspy/.github@c5376fc?
Still trying to run
git remote add upstream https://github.com/hyperspy/lumispy.git
: https://github.com/LumiSpy/lumispy/actions/runs/8944482220/job/24571487005?pr=211
OK, now I figured that I have to pass the ORGANISATION and it is running through :-)
Is it worth updating the doc workflow? For example:
I see that the [push_doc.yml](https://github.com/hyperspy/.github/blob/main/.github/workflows/push_doc.yml)
workflow relies on tokens that can probably not be shared across organisations?
Which tokens?
This is the workflow: https://github.com/hyperspy/.github/blob/main/.github/workflows/doc.yml
doc.yml
uses push_doc.yml
, which uses access tokens: https://github.com/hyperspy/.github/blob/c5376fc1205d57561ac5e15620df4e5799465a5c/.github/workflows/push_doc.yml#L83
I'll merge this PR and the doc workflow could become a new one.
Description of the change
pyproject.toml
to replacesetup.py
(see e.g. https://github.com/hyperspy/holospy/pull/14)Update release workflow to match the one of HyperSpy and other extensions. Related todo:
Progress of the PR
upcoming_changes
,