LumiSpy / lumispy

Luminescence data analysis with HyperSpy.
https://lumispy.org
GNU General Public License v3.0
25 stars 17 forks source link

Migrate to pyproject.toml, activate towncrier, update release workflow #211

Closed jlaehne closed 2 months ago

jlaehne commented 2 months ago

Description of the change

Progress of the PR

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (681442a) to head (dc82df1). Report is 1 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #211 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 13 12 -1 Lines 565 552 -13 ========================================= - Hits 565 552 -13 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jlaehne commented 2 months ago

@ericpre is there a way to make the hyperspy package_and_test workflow available for lumispy or should I work on simplifying the copy made here instead? As far as I can see, in particular `l65 is incompatible with being called from outside the hyperspy organization.

ericpre commented 2 months ago

Can you try now after https://github.com/hyperspy/.github/commit/c5376fc1205d57561ac5e15620df4e5799465a5c?

jlaehne commented 2 months ago

Can you try now after hyperspy/.github@c5376fc?

Still trying to run git remote add upstream https://github.com/hyperspy/lumispy.git: https://github.com/LumiSpy/lumispy/actions/runs/8944482220/job/24571487005?pr=211

jlaehne commented 2 months ago

Can you try now after hyperspy/.github@c5376fc?

Still trying to run git remote add upstream https://github.com/hyperspy/lumispy.git: https://github.com/LumiSpy/lumispy/actions/runs/8944482220/job/24571487005?pr=211

OK, now I figured that I have to pass the ORGANISATION and it is running through :-)

jlaehne commented 2 months ago

Is it worth updating the doc workflow? For example:

I see that the [push_doc.yml](https://github.com/hyperspy/.github/blob/main/.github/workflows/push_doc.yml) workflow relies on tokens that can probably not be shared across organisations?

ericpre commented 2 months ago

Which tokens?

This is the workflow: https://github.com/hyperspy/.github/blob/main/.github/workflows/doc.yml

jlaehne commented 2 months ago

doc.yml uses push_doc.yml, which uses access tokens: https://github.com/hyperspy/.github/blob/c5376fc1205d57561ac5e15620df4e5799465a5c/.github/workflows/push_doc.yml#L83

I'll merge this PR and the doc workflow could become a new one.