Separate implementations from (core)-Editor

Lumieducation / H5P-Nodejs-library

h5p-nodejs-library is a collection of server and client-side packages that help you use H5P with a NodeJS backend

https://docs.lumi.education

GNU General Public License v3.0

157 stars 77 forks source link

Separate implementations from (core)-Editor #154

Closed JPSchellenberg closed 4 years ago

JPSchellenberg commented 5 years ago

After thinking about the code for a bit I noticed that some of our files in src/ are basically implementations:

FileContentStorage.ts
EditorConfig.ts
FileLibraryStorage.ts
InMemoryStorage.ts
JsonStorage.ts
User.ts

I think we should keep them in the Repo as examples and some kind of default implementations, but separate them from the source-code in src/ as it makes it clearer how to implement the library.

@sr258 What do you think?

sr258 commented 5 years ago

Yes, I'm fine with moving them to some "implementation" folder or something like this. We should definitely keep them at hand, though, as they are needed by many tests.