search

LuminanceHDR / LuminanceHDR

A complete workflow for HDR imaging
http://qtpfsgui.sourceforge.net/
GNU General Public License v2.0
598 stars 103 forks source link

Luminance HDR Crash Linux Mint 19.1 #194

Open ghost opened 5 years ago

ghost commented 5 years ago

Was working with Luminance HDR, and attempted to activate the anti-ghosting. About 25% through the process, the entire computer crashed, and had to pull power and reboot. Happened once before with anti-ghosting, but I forgot and tried it again. Linux Mint 19.1 MSI X399 motherboard Ryzen Threadripper 1950X

heckflosse commented 5 years ago

@fcomida Franco, could that be related to this two issues found by cppcheck?

[H:/lhdr/src/HdrWizard/AutoAntighosting.cpp:209] (style) The unsigned expression 'y+dy' will never be negative so it is either pointless or an error to check if it is. [unsignedLessThanZero]
[H:/lhdr/src/HdrWizard/AutoAntighosting.cpp:211] (style) The unsigned expression 'x+dx' will never be negative so it is either pointless or an error to check if it is. [unsignedLessThanZero]
fcomida commented 5 years ago

@heckflosse I don't think so. If he just activated auto ag, dx = dy = 0 anyway. I can activate auto/manual ag in my computers (all running linux) with no crashes. The result is far from perfect in most cases but it doesn't crash. I experimented with a different deghosting algorithm too and I think I can trace many difficulties in making deghosting work properly in issue #107. No consinstent results, for instance, if I load three jpegs or three RAWs (same scene with "ghosts", RAWs converted to jpegs). Probably it would be better to disable ag completely for now.

heckflosse commented 5 years ago

I don't think so. If he just activated auto ag, dx = dy = 0 anyway.

Ok

heckflosse commented 5 years ago

@fcomida Did you get my post on pixls.us concerning copy constuctors?