search

Luminarys / synapse

Synapse BitTorrent Daemon
https://synapse-bt.org
ISC License
853 stars 48 forks source link

Replace OpenSSL with Rustls #192

Closed Luminarys closed 4 years ago

Luminarys commented 4 years ago

The Rust sha-1 crate appears to have a reasonably performant implementation now, we can start migrating off of openssl by switching this over.

Fixes #191

Luminarys commented 4 years ago

Turns out the overall change is not so bad. While I've done my own manual testing to verify this change there are no comprehensive tests around this code sadly (integration tests around networking kind of suck to write even though they should be there). I'll leave this PR open a bit if anyone wants to leave feedback (I believe there should be no visible changes in behavior).

Luminarys commented 4 years ago

One other significant benefit here is that the stripped release binary size of synapse has been reduced 20% from 7.3 MB to 5.9 MB.