search

Luminarys / synapse

Synapse BitTorrent Daemon
https://synapse-bt.org
ISC License
855 stars 48 forks source link

Tracker: chunked encoding? #226

Closed mayli closed 11 months ago

mayli commented 2 years ago

There are few trackers using chunked encoding and the chunk length is treated as part of body and causing bdecode failure. Any plan to support it?

Alternatively, the tracker client should report itself as http/1.0 to avoid handling the chunked encoding.

Luminarys commented 2 years ago

If you're able I'd be happy to accept a change which reports our HTTP client as 1.0 to trackers. Not sure if there's any unintended potential side effects there. I think in theory we ought to use httparse to properly parse out chunks though.

Luminarys commented 2 years ago

Oh I totally missed your patch. Thanks!

marieell commented 12 months ago

This was fixed in bae263b1ab00b83b9c25f5f2f72cf3574ab23fb8 and can be closed now :)