Lumiwealth / quantstats_lumi

Apache License 2.0
53 stars 20 forks source link

Regression with active returns in reports.py #13

Closed kartiksubbarao closed 5 months ago

kartiksubbarao commented 5 months ago

The #7 pull request for #6 fixed an issue with active_returns. However, this change was inadvertently reverted in a subsequent commit https://github.com/Lumiwealth/quantstats_lumi/commit/784452d0c6a14aaff595a0fe26845342be25ff95

[That commit also reverted the #8 fix, which solves another mystery I had yesterday :-)]

I will submit another pull request to re-apply the fix.