Lumiwealth / quantstats_lumi

Apache License 2.0
53 stars 20 forks source link

noisy warning messages about Dataset variance #15

Closed kartiksubbarao closed 5 months ago

kartiksubbarao commented 5 months ago

Sometimes with small datasets, _sns.kdeplot() will complain UserWarning: Dataset has 0 variance. This doesn't really add value as it's obvious from the quantstats charts, and it just adds to noise in log files. There is a simple option to turn that off: warn_singular=False. I'll submit a pull request for that, it would be great if we can silence these noises :-)

kartiksubbarao commented 5 months ago

Thanks @grzesir, appreciate your stewardship of this project!

grzesir commented 5 months ago

Thanks @grzesir, appreciate your stewardship of this project!

@kartiksubbarao No problem. Not sure why the original author abandoned it, but I'm a huge fan and we use it a lot in our library, lumibot. If you haven't seen our library yet, I think you'll really like it.