search

Lumiwealth / quantstats_lumi

Apache License 2.0
93 stars 32 forks source link

qs.reports.html compounded=False not accurate for Calmer / ROMaD / RaR #29

Open Koha101 opened 7 months ago

Koha101 commented 7 months ago

When calling qs.reports.html with the compounded=False argument, the Calmer and ROMaD are calling the CAGR function without passing the compounded argument. This defaults CAGR to calculate with compounded=True for the two calculations, overestimating the Calmer and ROMaD.

I don't use RaR, but it seems like compounded is not passed to CAGR for it as well.

grzesir commented 6 months ago

Why do you think that compounded=True is incorrect?

Robert Grzesik 347-635-3416

On Mon, Apr 22, 2024 at 4:36 PM Koha101 @.***> wrote:

When calling qs.reports.html with the compounded=False argument, the Calmer and ROMaD are calling the CAGR function without passing the compounded argument. This defaults CAGR to calculate with compounded=True for the two calculations, overestimating the Calmer and ROMaD.

I don't use RaR, but it seems like compounded is not passed to CAGR for it as well.

— Reply to this email directly, view it on GitHub https://github.com/Lumiwealth/quantstats_lumi/issues/29, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIYQK4CNFJUVKH2UIQARXDY6VYFNAVCNFSM6AAAAABGTPDXGOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGI2TONBRHEZTGNA . You are receiving this because you are subscribed to this thread.Message ID: @.***>