Closed mylesgamez closed 4 months ago
My review is in progress :book: - I will have feedback for you in a few minutes!
I have reviewed your code and found 4 potential issues. To discuss my individual comments that I have added, tag me in replies using @korbit-ai.
Please react with a 👍 to my comments that you find helpful and a 👎 to those you find unhelpful - this will help me learn and improve as we collaborate.
Tested all new functions / unit test cases with cmnd: python3 -m unittest discover -s quantstats_lumi/tests
Description by Korbit AI
What change is being made?
Implemented annualized return, alpha, and beta portfolio metrics with corresponding unit tests.
Why are these changes being made?
These changes introduce essential financial metrics to the codebase, enhancing the library's capability to evaluate portfolio performance. The unit tests ensure the accuracy and reliability of these new functions, covering various scenarios including positive, negative, and mixed returns, as well as edge cases like non-numeric and empty inputs.