Remove _utils._prepare_returns option in monthly_returns_detailedview

twkim112 commented 3 months ago

The _utils._prepare_returns caculation was already defined in the corresponding core function
Removing it from monthly_returns_detailedview to avoid duplication and potential conflicts

Description by Korbit AI

[!NOTE] This feature is in early access. You can enable or disable it in the Korbit Console.

What change is being made?

Remove the _utils._prepare_returns option in the monthly_returns_detailedview function.

Why are these changes being made?

The _prepare_returns option was redundant and its functionality is now handled elsewhere in the codebase, simplifying the function signature and reducing unnecessary complexity. This change ensures that the monthly_returns_detailedview function is more streamlined and easier to maintain.

korbit-ai[bot] commented 3 months ago

My review is in progress :book: - I will have feedback for you in a few minutes!

korbit-ai[bot] commented 3 months ago

I have reviewed your code and did not find any issues!

Please note that I can make mistakes, and you should still encourage your team to review your code as well.

Lumiwealth / quantstats_lumi