LumoSQL / archive1-LumoSQL-on-github

Initial work on SQLite and LMDB integration
https://lumosql.github.io/LumoSQL/
Other
67 stars 14 forks source link

Remove sqlite3BtreeGetJournalname() from src/vdbeaux.c #63

Closed danshearer closed 3 years ago

danshearer commented 4 years ago

Describe the bug

sqlite3BtreeGetJournalname() is a journal-mode-specific BTree-specifc function only called once, in vdbeaux.c .

The purpose of this seems to be to abort if the pager says journal/WAL filenames aren't relevant. However we need to intercept this higher up, to allow for alternative backends altogether.

So we should change this function call in vdbeaux.c to be sqlite3BtreeAbortCommit(), which will call sqlite3BtreeGetJournalname() in the case that standard btree is in use.

danshearer commented 3 years ago

Now in https://lumosql.org/src/lumosql/tktview/64a89acddb61e3c7f74692a46ba41dfd3f35d1047