search

LunaMultiplayer / LunaMultiplayer

Multiplayer mod for Kerbal Space Program (KSP)
http://www.lunamultiplayer.com
MIT License
447 stars 152 forks source link

Support Breaking Grounds' Deployable Science #308

Open AlexFaraino opened 5 years ago

AlexFaraino commented 5 years ago

Server OS: Linux Client OS : Windows

KSPVersion: 1.7.3

LMP version (include the build number if you are using a nighly build):

MODS (add link to download them): None

Expected behaviour: when deployable science is deployed on a planet, it should stay at the same place, in the same state. As Breaking Ground is a supported expansion, this should work. On LMP server, a "Vessel" file should be created, corresponding to the Deployed science module.

Current behavior: the deployable science modules vanish when reconnecting to the server On LMP server, no Vessel is created. Thus, Deployable Science is not persistent in Universe.

Steps to reproduce:

  1. Create a simple vessel with deployable science module : Experiment Control Station and a Photovoltaic Panel
  2. Launch and land outside of safety bubble (preferably out of KSC biome)
  3. Install the two science modules
  4. Leave the vessel here and go to KSC's Tracking Station : you can see the vessel and the "Deployed Science" control station.
  5. Disconnect from the server and reconnect immediately
  6. Go to the tracking station: the Deployed Science control station is gone.
  7. Select the Vessel and click Fly
  8. The Deployed Science control station is gone too :(

My investigations: I dig a bit in KSP saved game file and discovered that the game is saving the Universe in the file persistent.sfs. In this file, the deployed science are stored like vessels, with a specific type (like Flags, actually). See the attached file: DeployedScience Vessels.txt

Can you please add support for this?

theAdmin10 commented 2 years ago

This is still an issue, using KSP 1.12.3.3173 and LMP 0.28.0. The Probodobodyne Control Module is the only thing that remains. All power units and science modules disappear.

Possibilities: It is possible, the clean up routines after recovering the Kerbal or Original Vessel is "cleaning up" the original vessel and any of it's "debris." The system may be considering the deployed modules as "debris."

ungerrj commented 2 years ago

It looks like the existing game events hooked by the client for vessel creation don't cover the (new in Breaking Ground) events that are used to indicated ground science is being deployed; the client never knows about the vessel(s), so the server never learns about the vessel(s).

I've had some local success addressing this... doing some cleanup and testing as well as taking a look at if there is any need for update to scenario handling to ensure the ground science progress/status changes are synced. I hope to provide a pull request for this within a few days.

ItsK1tty commented 1 year ago

Sorry about rushing things, but any progress with the pull request?

webmilio commented 1 year ago

I'd really like for this to be fixed as well.

Oliepolie commented 1 year ago

I apologize for the bump but this is still an issue, just in case AutoNuke and AutoDekessler have both been disabled and it still exhibits the same behavior. Occasionally the deployable science experiments stay after returning to the tracking station but always disappear within a few minutes or perhaps the next launch anyways.