LunaPixelStudios / Medieval-MC

https://lunapixel.studio/discord
https://lunapixel.studio/discord
15 stars 9 forks source link

MMC 2: Zenith mod: Placing items into salvaging table instantly crashes the game #804

Closed LiliKyri closed 1 month ago

LiliKyri commented 2 months ago

Describe the Bug

As above: when attempting to place items such as gems into the salvaging table in order to use it, the game freezes and then promptly crashes the moment the item is placed into the GUI.

Noticed in the version updates for the modpack that the most recent version contains an update to the GUI of the zenith mod and its blocks, so I suspect the issue lies therein.

Succinct error message generated by minecraft: "The game crashed whilst rendering screen Error: java.lang.NullPointerException: Cannot invoke "net.minecraft.client.gl.ShaderProgram.addSampler(String, Object)" because "$$2" is null"

Reproduction Steps

  1. Open the salvaging table from the Zenith mod
  2. Place gem (or any item) into the salvaging table
  3. Game freezes
  4. Crash

Screenshots and Videos

No response

Crash Report or Log

https://pastebin.com/c5Sj7vWz

Operating System

Windows 11

Minecraft Version

1.20.1

Modloader

Fabric

Modpack Version

v25

Other Mods

N/A

muon-rw commented 2 months ago

This is a rendering bug with Zenith itself - we can't use the updated version yet with its fix as it conflicts with Obscure API. (See here: https://github.com/TheWinABagel/ZenithAttributes/issues/32)

If they don't merge this fix or do some other workaround soon, we'll likely downgrade Zenith in the next modpack update.

You can also update both Zenith and Zenith Attributes and remove Aquamirae+Obscure API, if those mods aren't important to you.

LiliKyri commented 2 months ago

Worked a charm

Thank you btw for the fixes and responses and forums and such. You and yall are the most involved and courteous modpack devs I've encountered

muon-rw commented 1 month ago

Looks like Zenith Attributes merged the PR, we'll include these in an update soon