search

LunaPixelStudios / Medieval-MC

https://lunapixel.studio/discord
https://lunapixel.studio/discord
15 stars 9 forks source link

Poisoned weapons don't apply looting #807

Closed 100lewi closed 1 month ago

100lewi commented 1 month ago

Describe the Bug

Seems when you poison a weapon using the skill in the skilltree that lets you add harmful potion effects it doesn't count as the player killing it. This is also not in line with a player throwing a potion while holding a looting sword, when you do that you get the looting applied. So I'm guessing the damage from the "poisoned" sword is just missing something to flag it as x players damage.

Reproduction Steps

  1. Combine a potion with a sword with looting on it (I used potion of harming with a wooden sword with looting 5)
  2. Kill something a couple times (I used chickens)
  3. Compare with killing without the potion on

Screenshots and Videos

No response

Crash Report or Log

No response

Operating System

Windows 10

Minecraft Version

1.20.1

Modloader

Forge

Modpack Version

v27

Other Mods

No response

100lewi commented 1 month ago

I understand that this might be a issue with the skilltree mod but I wasn't sure if this was stuff you guys added or not so I made the issue here just to be safe

muon-rw commented 1 month ago

Hi, this would definitely be a Passive Skill Tree bug moreso than us, especially since we’re just using the default tree.

https://github.com/Daripher/Passive-Skill-Tree/issues