LunaPixelStudios / SteamPunk

7 stars 3 forks source link

Incompatibility with Create Mod Schematics #338

Open Routhinator opened 9 hours ago

Routhinator commented 9 hours ago

Describe the Bug

When using this mod in a build that you want to reproduce with a Create Schematic, the schematic cannot be used and causes a stack trace to be printed by Create with a warning. Specifically this seems to be the Inventory Cable Connector.

Historically this sort of thing used to cause a server crash. According to the Create Mod Devs this is usually because a mod is using an unsafe cast method (example https://github.com/Creators-of-Create/Create/issues/3641) - They have made it so it no longer causes a crash thankfully, however I would like to use this mod in schematics so reporting this in hopes that this will be rectified.

Log from Create:

[17:20:02] [Server thread/ERROR]: Failed to load Schematic for Printing
java.lang.ClassCastException: class com.simibubi.create.content.schematics.SchematicWorld cannot be cast to class net.minecraft.class_3218 (com.simibubi.create.content.schematics.SchematicWorld and net.minecraft.class_3218 are in unnamed module of loader 'knot' @58651fd0)
    at com.tom.storagemod.tile.PaintedBlockEntity.markDirtyClient(PaintedBlockEntity.java:57) ~[toms_storage_fabric-1.20-1.6.8.jar:?]
    at com.tom.storagemod.tile.PaintedBlockEntity.method_11014(PaintedBlockEntity.java:40) ~[toms_storage_fabric-1.20-1.6.8.jar:?]
    at com.tom.storagemod.tile.InventoryCableConnectorBlockEntity.method_11014(InventoryCableConnectorBlockEntity.java:120) ~[toms_storage_fabric-1.20-1.6.8.jar:?]
    at net.minecraft.class_3499.method_15172(class_3499.java:262) ~[client-intermediary.jar:?]
    at com.simibubi.create.content.schematics.SchematicPrinter.redirect$ccl000$create_pattern_schematics$loadSchem(SchematicPrinter.java:586) ~[create-fabric-0.5.1-f-build.1417+mc1.20.1.jar:?]
    at com.simibubi.create.content.schematics.SchematicPrinter.loadSchematic(SchematicPrinter.java:103) ~[create-fabric-0.5.1-f-build.1417+mc1.20.1.jar:?]
    at com.simibubi.create.content.schematics.cannon.SchematicannonBlockEntity.initializePrinter(SchematicannonBlockEntity.java:460) ~[create-fabric-0.5.1-f-build.1417+mc1.20.1.jar:?]
    at com.simibubi.create.content.schematics.cannon.SchematicannonBlockEntity.tickPaperPrinter(SchematicannonBlockEntity.java:684) ~[create-fabric-0.5.1-f-build.1417+mc1.20.1.jar:?]
    at com.simibubi.create.content.schematics.cannon.SchematicannonBlockEntity.tick(SchematicannonBlockEntity.java:287) ~[create-fabric-0.5.1-f-build.1417+mc1.20.1.jar:?]
    at com.simibubi.create.foundation.blockEntity.SmartBlockEntityTicker.tick(SmartBlockEntityTicker.java:15) ~[create-fabric-0.5.1-f-build.1417+mc1.20.1.jar:?]
    at net.minecraft.class_2818$class_5563.method_31703(class_2818.java:662) ~[client-intermediary.jar:?]
    at net.minecraft.class_2818$class_5564.method_31703(class_2818.java:716) ~[client-intermediary.jar:?]
    at net.minecraft.class_1937.method_18471(class_1937.java:470) ~[client-intermediary.jar:?]
    at net.minecraft.class_3218.method_18765(class_3218.java:390) ~[client-intermediary.jar:?]
    at net.minecraft.server.MinecraftServer.method_3813(MinecraftServer.java:897) ~[client-intermediary.jar:?]
    at net.minecraft.server.MinecraftServer.method_3748(MinecraftServer.java:824) ~[client-intermediary.jar:?]
    at net.minecraft.class_1132.method_3748(class_1132.java:105) ~[client-intermediary.jar:?]
    at net.minecraft.server.MinecraftServer.method_29741(MinecraftServer.java:671) ~[client-intermediary.jar:?]
    at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:265) ~[client-intermediary.jar:?]
    at java.lang.Thread.run(Thread.java:840) ~[?:?]

Reproduction Steps

  1. Use Toms Storage in a build
  2. Make a schematic with Create Mod
  3. Attempt to use the schematic

Screenshots and Videos

2024-11-16_17 40 30

Crash Report or Log

No response

Operating System

Linux

Minecraft Version

1.20.1

Modloader

Fabric

Modpack Version

NA, only two mods needed to recreate this are Tom's Storage and Create v0.5.1-f-build.1417 (Latest for Fabric)

Other Mods

As mentioned I've tested and confirmed the only two mods required are Create+Tom's Storage, however for full list see: https://modrinth.com/modpack/magpunkrpg/version/0.17.1

This is a new pack I am prototyping so it's not public/released.

Routhinator commented 9 hours ago

... I added version 1.20.1 and Github actions added labels for every version but 1.20.1 - :laughing: Good job AI.

just to be certain, I have not tested outside 1.20.1