search

LunaTTvBot / LunaBot

0 stars 1 forks source link

Settings Handling #53

Closed iPaat closed 8 years ago

iPaat commented 8 years ago

After ( #48 ) is done we need to improve our Settings Handling. Within GUI development I tackled this with:

https://github.com/SuNflOw1991/iBot/blob/66bbb668d8978ba59e1cd8beaed7beb0aada48b5/iBot/Misc/Settings/SettingsBase.cs

and

https://github.com/SuNflOw1991/iBot/blob/66bbb668d8978ba59e1cd8beaed7beb0aada48b5/iBot/Misc/Settings/ConnectionSettings.cs

as explicit settings.

With this we could have our Plugins to have its own settings which they could manage via a 'SettingsManager'. It also should be possible to call other Plugins settings within a Plugin.

SettingsManager base (needs to be extended so that we don't need methods for every settings): https://github.com/SuNflOw1991/iBot/blob/66bbb668d8978ba59e1cd8beaed7beb0aada48b5/iBot/Misc/SettingsManager.cs

CapCalamity commented 8 years ago

I like the separation between the three files, but the SettingsManager should be able to hold more than one setting at a time.

We could let the SettingsBase implement an interface that requires at a name.
Then, the Manager can hold a list of that interface, and give options to set / get properties of those objects