search

Lunakepio / Mario-Kart-3.js

https://lunakepio.github.io/Mario-Kart-3.js/
MIT License
4.3k stars 950 forks source link

Partially implemented back navigation (addresses issue #20) #24

Closed somunaexe closed 6 months ago

somunaexe commented 6 months ago

I added the variables to store the escape key for back navigation but had some trouble implementing the actual navigation to the landing page hence why I said "partially implemented".

vercel[bot] commented 6 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mario-kart-3-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2024 7:10am
Tazi0 commented 6 months ago

Hi, maybe this tutorial could help you with your Pull request https://react.dev/learn/sharing-state-between-components, this tutorial is relevant because Landing.jsx contains a state: https://github.com/Lunakepio/Mario-Kart-3.js/blob/4d0200845c54e65e2c4e0d0a861e42ed33b6ba8a/src/Landing.jsx#L11 and: https://github.com/Lunakepio/Mario-Kart-3.js/blob/4d0200845c54e65e2c4e0d0a861e42ed33b6ba8a/src/Landing.jsx#L6 which you will need to change

Tazi0 commented 6 months ago

I just found out this issue was fixed at: https://github.com/Lunakepio/Mario-Kart-3.js/pull/26