Lunakepio / Mario-Kart-3.js

https://lunakepio.github.io/Mario-Kart-3.js/
MIT License
4.3k stars 950 forks source link

feat: replace JSX with TSX for type safety #35

Open bartzalewski opened 5 months ago

bartzalewski commented 5 months ago

use as a starting point (?)

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mario-kart-3-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2024 11:00pm
ShashankSuresh commented 5 months ago

For the file/workspaces/Mario-Kart-3.js/src/components/models/items/Banana_peel_mario_kart.tsx

please add props

type BananaProps = {
  onCollide?: number, 
  id: number, 
  position: number, 
  setNetworkBananas: SetStateAction<void>, 
  networkBananas: number
}
bartzalewski commented 5 months ago

Hi - Good work in adding typescript.

We have a few areas where typescript is complaining. Could you please fix them?

There are lots of areas where TypeScript is complaining. I think I would need some help here.

ShashankSuresh commented 5 months ago

Hey. How can I help? Can you let me know how I can contribute the same PR?

bartzalewski commented 5 months ago

Hey. How can I help? Can you let me know how I can contribute the same PR?

I believe every file in which there's a TypeScript error, must be fixed.

ShashankSuresh commented 5 months ago

Hey. How can I help? Can you let me know how I can contribute the same PR?

I believe every file in which there's a TypeScript error, must be fixed.

Yeah. If you give me permission to fork this repo or raise a PR from the main repo, I can fix those type issues. First, we need to merge your PR. What do you suggest?

bartzalewski commented 5 months ago

Hey. How can I help? Can you let me know how I can contribute the same PR?

I believe every file in which there's a TypeScript error, must be fixed.

Yeah. If you give me permission to fork this repo or raise a PR from the main repo, I can fix those type issues. First, we need to merge your PR. What do you suggest?

Hmm, I didn't see any issues caused by my code, so I think it's ok to merge.

ShashankSuresh commented 5 months ago

Hey. How can I help? Can you let me know how I can contribute the same PR?

I believe every file in which there's a TypeScript error, must be fixed.

Yeah. If you give me permission to fork this repo or raise a PR from the main repo, I can fix those type issues. First, we need to merge your PR. What do you suggest?

Hmm, I didn't see any issues caused by my code, so I think it's ok to merge.

I think so too. My only worry is if there is any linters during the build process. Anyway, please let me know once it's merged. I'll raise a new PR with the types fixed. 😀

bartzalewski commented 5 months ago

Hey. How can I help? Can you let me know how I can contribute the same PR?

I believe every file in which there's a TypeScript error, must be fixed.

Yeah. If you give me permission to fork this repo or raise a PR from the main repo, I can fix those type issues. First, we need to merge your PR. What do you suggest?

Hmm, I didn't see any issues caused by my code, so I think it's ok to merge.

I think so too. My only worry is if there is any linters during the build process. Anyway, please let me know once it's merged. I'll raise a new PR with the types fixed. 😀

cc: @Lunakepio

ShashankSuresh commented 5 months ago

Whats the latest update on this?