Lunakepio / Mario-Kart-3.js

https://lunakepio.github.io/Mario-Kart-3.js/
MIT License
4.3k stars 950 forks source link

chore: Add loading spinner to index.html #59

Open mvdbastos opened 1 month ago

mvdbastos commented 1 month ago

I came here because of this video of theo: https://youtu.be/mvqPWay9ABI?si=wiPwwABnu7CIh4BQ, I want to contribute with this project and I was thinking about making a simple mod in index.html where you can load a pure css spinner that can appear for the user before the React Three Fiber loader starts and make its own things. screencapture-2024-07-14 230203 I thought about it because a lot of people with bad connection will instead see a white screen with no clue about what's happening and may think the site is just broken an leave the site before the experience even begin. example without the css spinner: screencapture-2024-07-14 231257 simulating a 3G network, the user may have to wait for more than 20 seconds to even see the R3F loading screen

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mario-kart-3-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2024 10:16pm
netlify[bot] commented 1 month ago

Deploy Preview for lively-starlight-93e01a ready!

Name Link
Latest commit 616102410585d816d6f39d0f29763d9a4e841132
Latest deploy log https://app.netlify.com/sites/lively-starlight-93e01a/deploys/66944e22e981f80008f451ef
Deploy Preview https://deploy-preview-59--lively-starlight-93e01a.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.