gPathToSuggestedInteractionProfileBinding should be keyed from InstanceInfo because it's a map with key XrPath, which is Instance-specific.

LunarG / OpenXR-OverlayLayer

Implementation of the OpenXR Overlay extension as a layer

Other

64 stars 17 forks source link

gPathToSuggestedInteractionProfileBinding should be keyed from InstanceInfo because it's a map with key XrPath, which is Instance-specific. #20

Closed bradgrantham-lunarg closed 3 years ago

bradgrantham-lunarg commented 3 years ago

It's a global in the generated source, emitted in generate.py around line 817.

jzulauf-lunarg commented 3 years ago

@bradgrantham-lunarg -- this variable is defined but otherwise unreferenced. Is this a stale issue?

bradgrantham-lunarg commented 3 years ago

I think so. Generate.py says "# left here as breadcrumbs - xrSuggestInteractionProfileBindings is completely hand-written" before a snippet containing "gPathToSuggestedInteractionProfileBinding", so I'm guessing I rewrote the hooked SuggestInteractionProfileBindings and didn't use gPathToSuggestedInteractionProfileBinding in the rewrite. Issue may have been resolved but not closed.