- Added dependency on Eigen for basic vector math.

LunarG / OpenXR-OverlayLayer

Implementation of the OpenXR Overlay extension as a layer

Other

64 stars 17 forks source link

- Added dependency on Eigen for basic vector math. #9

Closed michaelplutovr closed 4 years ago

michaelplutovr commented 4 years ago

Added overlay sample based off of OverlayUser_Remote
Adeed basic interaction tests via a naive intersection with the plane and a toggle
added dependency on locating a xrloader lib for the sample.

bradgrantham-lunarg commented 4 years ago

When I build from this branch, I get 2>LINK : fatal error LNK1104: cannot open file '....\vendored\openxr_loader.lib'

I assume you want the developer to "mkdir vendored" and pull the loader lib into there.

How hard would it be to add a FindOpenXR or some such like FindFreeImage? How do other OpenXR projects find and use the openxr package?

Or could you co-opt the OPENXR_SDK_SOURCE_ROOT stuff from api-layer/CMakeLists.txt?

bradgrantham-lunarg commented 4 years ago

I think I'm going to pull this now, but we should resolve the vendored loader issue.

michaelplutovr commented 3 years ago

Brad,

These slipped past my radar. adding a Find module for them seems like the way to go, I can start work on a PR to patch that up Tomorrow. As a quick stop gap to unify the way things are found I'll focus on a pr that co-opts the OPENXR_SDK_SOURCE_ROOT.

On Wed, Sep 9, 2020 at 4:15 PM bradgrantham-lunarg notifications@github.com wrote:

Merged #9 https://github.com/LunarG/OpenXR-OverlayLayer/pull/9 into api-layer-rework.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/LunarG/OpenXR-OverlayLayer/pull/9#event-3748185958, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALY7VXBBSGABMYMTVRMIJ4DSFAD7TANCNFSM4QD2PNBQ .

bradgrantham-lunarg commented 3 years ago

Michael, a PR first that co-opts OPENXR_SDK_SOURCE_ROOT and then later one that adds a Find module would be great! In the meantime I've made a vendored directory myself for my build, and figured as this approached release I'd come back around to this issue.