Closed dorian-apanel-intel closed 1 month ago
I am not familiar with Qt5 however I played with the code and got it to start working. Someone forgot to change the Qt signal from triggered to toggled for the combo box options. The signal is not emitted for actions that are check-able so as a result the Configurators configure function is never called.
I will make a pull request with my fix.
@npavlicek Thank you very much for addressing the issue.
Initially, I was puzzled because the code modification seemed to pertain solely to the tray and not to the combo box. However, upon inspecting the code under a debugger, I noticed that UpdateTray
is invoked within the OnComboBoxModeChanged
method.
vkconfig.exe!MainWindow::UpdateTray() Line 212 C++
vkconfig.exe!MainWindow::UpdateUI() Line 347 C++
vkconfig.exe!MainWindow::OnComboBoxModeChanged(int index) Line 525 C++
The radio selection has been changed to a combo box:![image](https://github.com/LunarG/VulkanTools/assets/72810961/38324ad8-0460-4ac8-b761-3ad83b11af29)
However, if you only change the value of the combo box without clicking elsewhere, you might assume that the configuration has been updated when, in fact, it has not. This issue was not present with the radio selection that was used previously, which worked correctly.
Example:
set VK_LOADER_DEBUG=all
%VULKAN_SDK%\Bin\vulkaninfoSDK.exe > my_file.txt 2>&1
dir "%appdata%\..\Local\LunarG\vkconfig\override"
and note the presence of theVkLayer_override.json
andvk_layer_settings.txt
files.It was working correctly in radio selection present before
Observed on VulkanSDK binary package v.1.3.283.0